Did a very short session - reviewed the latest patch for Bug #2045816 “project-x fails to build from source in noble” : Bugs : project-x package : Ubuntu, made a slight modification to it to make a lintian-override more specific, then uploaded it. This is my first upload as an MOTU
-
linphone (LP: #2047458): Created a ppa for the patches, tested them, then sponsored with more descriptive patch filename
-
apache2 (LP: #1947459): Verified on my end, Sergio ended up sponsoring it
- Reviewed lxc bug to update the Debian package. Tried to clarify the merge process and also did some content review.
- Reviewed backport-iwlwifi-dkms bug to fix upstream versioning change. The submitter wants to add a epoch to the version string, I am not so confident of that so did not upload the package. I believe a broader consensus is needed before performing the upload.
- Took a look at the xorg-server MP. schopin mentioned he pinged someone with xorg knowledge to review the patch but I did not find any info about this in the hand-off discourse post. Decided to not act on it since I also do not have much knowledge on xorg.
-
Reviewed MP to merge ldapscripts from Debian:
- Bug #2049311 “Please merge ldapscripts 2.0.8-2 (universe) from D...” : Bugs : ldapscripts package : Ubuntu
- My impression is that the Ubuntu delta currently in the archive is wrong, and we probably can drop it
- Replied to the MP asking for more information
-
Reviewed MP adding new patchset to xorg-server
- Merge into ubuntu/devel : tearfree : lp:~jeff250/ubuntu/+source/xorg-server : Git : Code : xorg-server package : Ubuntu
- The diff is big, I think it needs a review of somebody with some experience with the Xorg packages and QA processes. I commented on formal issues (dep-3 headers, missing bug reference, git commit history).
-
SRU double-free in Jammy iptables
- Bug #2049318 “[SRU] free(): double free detected in tcache 2” : Bugs : iptables package : Ubuntu
- Looks like a “patch on a plate” SRU case, but there are formal issues on the debdiff, I commented on those. Also: the upstream commit also a test for this issue, but that got dropped in the added d/patches patch. I asked to keep it, or to explain why we can’t.
No IRC pings to report.
I’d like to draw some attention on the xorg-server MP: the user clearly put some effort in preparing it, and it would be a pity to keep commenting on the nits (like I did) without being able to give actual feedback on the actual contents on the MP. I hope a future PP somehow familiar with xorg will be able to have a look at that diff.
- ldapscripts LP: #2049311 / MP 458569 a sync was already sponsored, so unsubscribed ubuntu-sponsors from the bug and marked the MP ‘Disapprove’
- rsyslog LP: #2045033 / MP 458725 the merge already sponsored, so set the bug status to ‘Fix Committed’ and marked the MP ‘Approve’
- cunit LP: #2049554 reviewed and sync’d
- freeradius LP: #2042824 / MR 458744 reviewed and sponsored SRU
- iptables LP: #2049318 reviewed and sponsored SRU
- There was a request on irc to help diaspora-installer migrate, it had been removed from the archive and had previous autopkgtest results, but
migration-reference/0
tests did not help. Added a hint to allow it to migrate
- #2046871: unsubscribed sponsors given there are two unanswered path pilot comments already
- xorg tearfree debdiff: out of my depth there, just added a simple comment, asked to rebase to noble-proposed, and subscribed @tjaalton
- #2039873: reviewed the noble debdiff, asking for changes to the DEP8 test.
-
apparmor userns for systemd-coredump: this looks OK now, changing just
systemd-coredump
's apparmor profile, but the security team should have the final say. Left my non-security +1 in the MP. - #2049188: just flipped the bug status to “fix committed”. The sponsorship report page I was following still had this in the queue, but it was already uploaded a few hours ago.
-
#2049715: was already uploaded by the time I got to it in my shift, but I noticed that the linked MP had a bug in that it still had
UNRELEASED
ind/changelog
, but LP accepted and built the package even so. - lektor MP: requested forwarding to debian, and DEP3 headers in the patches
- LP: #1971547 – cyradm fails on jammy; sponsored
- LP: #2044264 – mmv aborts with realloc; sponsored
- LP: #1875642 – FSVS - not able to commit changes to http SVN repo – reviewed and suggested minor change, but if that can be addressed this should be good to sponsor
-
LP: #2039873 – liblxc-dev built with
LXC_DEVEL=1
– reviewed current status; agreed quick-fix forLXC_DEVEL=1
is preferable way forward, suggested minor fix to DEP-8 test to check runtime files, not build-time, and addressed a minor build-failure on noble. Will sponsor for noble if someone can do a quick review of the changes
- MP #2050390: Left a comment asking the submitter to mention the bug being fixed in the changelog.
- MP #458934: Left comments requesting improvements to the MP.
- MP #459015: Left a comment asking for DEP-3 headers + some clarification re. the MP description.
- ltrace: already uploaded; marked MP as Merged
- xorg-server “tearfree”: this has been in the queue for a while and commented on by various people. The issue is that it is (good) original work that really belongs upstream rather than in a distro patch with a maintenance burden. Previous pilots have tried to help in this direction, but ultimately it doesn’t really belong in the queue since there is no action to take in Ubuntu. I marked the MP as “Work in progress” with an explanation and instructions on how to put it back in the queue again if the submitter needs.
- liblxc-dev LXC_DEVEL=1: again this has been commented on by various pilots. @waveform kindly said he’d take another look, rather than me adding yet another cook to spoil this broth.
- lektor update for werkzeug: again this has been commented on by previous pilots. The issue I have with sponsoring this is that it doesn’t seem to be possible to reconcile the patch against the upstream it is claimed to came from. I asked for details, and queried why we aren’t taking the upstream maintenance release that includes the necessary fixes.
- onionshare update for werkzeug: I asked about appropriate testing on this. Sure, it might make dep8 tests pass, but if we’re pushing ahead with selecting backports from upstream, does it actually fix the issue such that the app works again, and what’s the plan to verify this? I left a comment.
Some observations
The werkzeug work is important, but I wonder if it stretches a little beyond the capabilities of patch piloting. Same for liblxc-dev where the bug seems to have gone into a tangent about making more significant packaging updates than a simple patch.
I also noticed that the ~ubuntu-sponsors MP slot is being taken and thus MPs are disappearing from the queue. I’ve commented about this before but there was no further discussion on this point. I think I will probably just change the bot and queue to use ~ubuntu-sponsors-reporter when I get round it to work around this issue as I suggested. In the meantime, I think MPs are still being lost from the queue.
Sponsored fsvs, dotnet8 and lcov. Also investigated gettext which sadly had already been sponsored without git-ubuntu.
Looked at openssh, cinder and mutter but didn’t feel up to reviewing those more complex merges today.
Short flight today:
- Sponsored google-guest-agent for @kajiya on Friday(?), looks like @ahasenack sponsored a followup with some minor tweaks. I’ve reviewed those tweaks and now understand what I was missing on my end; thanks for the followup, I’ll be happy to sponsor the SRUs too if needed.
- I’ll volunteer to take ruby3.1, assuming @adrien can come up with a followup diff.
- Sponsored linux-media-player for
sudip
, that’s in the Jammy queue.
I’d recommend python-uefivars as a starting point for the next pilot.
Thanks!
Many things from the sponsoring report are currently in-flight and I was mostly side-tracked helping out with the time_t transition NMUs in Debian, so didn’t get a lot of stuff done, but at least I could clean up a little bit:
Minor housekeeping on open bugs and MPs. Open context:
- Merge into ubuntu/devel : ubuntu/devel : lp:~kennybobs/ubuntu/+source/debootstrap : Git : Code : debootstrap package : Ubuntu
- This was discussed already by previous patch pilots, with no clear consensus on the action to take. I dug a bit deeper in the issue and suggested alternative approaches and in general requested more information.
- Bug #2051908 “autopkgtests fail with for version 5.0~1-4” : Bugs : asterisk-espeak package : Ubuntu
- I suggested an alternative approach which does not involve adding a quilt patch. In case the patch is retained, I asked for dep-3 headers.
- Bug #2042849 “[needs-packaging] xlnx-platformstats package from ...” : Bugs : Ubuntu
- This was removed from the sponsorship queue, but I had a cursory look at the packaging, reported a FTBFS (now fixed), reported lintian issues (including an error), and suggested to drop a quilt patch in favor of a variable override done via the environment.
IRC activity: handover comments between pilots. No users’ questions/requests.
- Bug #2051074 “Mirror mode doesn't work when panel only supports ...” : Bugs : mutter package : Ubuntu - patches for mutter, submitter already working on upstreaming this to Salsa, unsubscribed Sponsors and left a note
- Merge into debian/sid : merge-lp2051576-noble : lp:~danilogondolfo/ubuntu/+source/sudo : Git : Code : sudo package : Ubuntu - left minor suggestion related to git-ubuntu and uploaded
- Bug #2051695 “autopkgtests fail with 4.9-1build1” : Bugs : ccache package : Ubuntu - upstream posted a fix since the MP opened, suggest preferring the upstream fix. Submitter agrees. Manually synced.
- A few MPs had already been uploaded but were still on the report. Note added to MPs and closure requested.
- Bug #2046994 “Spotlight search function broken with macOS Ventur...” : Bugs : samba package : Ubuntu - reviewed, uploaded for focal & jammy
- aubio LP: #2051990 fixed in Debian, sponsored a sync
- bdebstrap LP: #2051997 fixed in Debian, sponsored a sync
- mirage LP: #2052559 sponsored a sync
- pexpect LP: #2052423 sponsored a sync
- ccdproc LP: #2052375 sponsored a sync
- factory-boy LP: #2051977 / MP 459838 reviewed and sponsored
- unzip LP: #2051952 already uploaded, unsubscribed ubuntu-sponsors
- glueviz LP: #2052370 / MP 459975 reviewed and sponsored
- apprise MP 459961 reviewed and left a comment
- gigolo LP: #1993899 reviewed and sponsored SRUs
- There was a request on irc to mark two bugs as being affected on Jammy, which I did, and also answered a question about the current state of auto-sync from Debian.
- Bug #2039036 “[needs-packaging] optee-client-s32” : Bugs : Ubuntu : Left a comment with some points that need to be addressed before the package is uploaded to NEW again.
- Bug #2051895 “Lenovo XT99 BT headset can't work in HFP profile” : Bugs : pulseaudio package : Ubuntu : Left a comment asking the reporter to add DEP-3 headers and improve the changelog message (I was going to add the DEP-3 headers myself to save the round trip, but after seeing the changelog message I decided it was worth pinging him).
- Bug #2051199 “Add MediaTek Genio mt8370 support and update mt839...” : Bugs : alsa-ucm-conf package : Ubuntu : Left a comment asking the reporter to add DEP-3 headers to the series of patches he’s adding.
- Bug #2052724 “test_skip_verbose fails on python3.12” : Bugs : django-rich package : Ubuntu : Left a comment in the MP asking the reporter to add DEP-3 headers to the patch and provide autopkgtest logs proving that the fix works.
- Bug #2052578 " 2.4.4+dfsg1-1 is FTBFS on armhf in Noble” : Bugs : 389-ds-base package : Ubuntu : It seems to me that it should be possible to fix the problem in a simpler way, so I left a comment asking more information.
- Provided some guidance on IRC to a person interested in helping with the nodejs migration.
- Bug #2052493 “apparmor profile does not allow for rotating savef...” : Bugs : tcpdump package : Ubuntu : Sponsored after some adjustments, build, test, etc. Also provided some suggestions for next time she wants something sponsored, and left a comment asking her to take a look at Mantic/Noble because the testcase provided in the bug generates a segfault there.
- Looked through the walinuxagent merge, but it seems Lucas has things well in hand there, and given the complexity of the patch I’m inclined to wait for his review of Calvin’s recent revision before taking any further action.
- LP: #2039037 – Reviewed
optee-test-s32
and left some suggestions and requests - LP: #2034650 – Reviewed and sponsored
uboot-s32
with some minor adjustments to the changelog - Skipped the no-esm merges as those are pending reviews from specific interested parties
- LP: #2051908 – Reviewed; pending concerns from prior reviewers, unsubscribed ubuntu-sponsors until these are addressed
- LP: #2051270 – Reviewed and sponsored
sysdig
SRU - LP: #2040059 – Reviewed and intending to sponsor
sagemath
pending a local build; would be a no-change rebuild but for a horrid need to bump the arbitrary “tolerated build failures” number (but given that’s already 200 (!) by default, and the application is in a completely-broken-won’t-even-launch state, what’s 30 more … urgh!)