-
LP: #2007702: asked the reporter to fix the version numbers for the SRU candidates and pointed to the SRU policy.
-
LP: #2041171: removed ubuntu-sponsors, patch already uploaded.
-
LP: #2042902: asked the reporter to fix the version number for the mantic SRU candidates, pointed to the SRU policy, and asked them to adjust the trackers for each series.
-
- Continuation of the work of @paride 10 days ago and @athos-ribeiro 1 day ago.
- I got an IRC ping as well even before finding it in the queue
- Playing this as āplease do Xā ping pong would not complete anytime soon, but sadly the requester was not available for direct discussion. So as fallback I provided a case study and reasoning/material to study how it should be done to learn from.
- uploaded to noble, once good there and updates to the SRU uploads have been made it can be sponsored there
-
Ping about zlib sponsoring: I didnāt have time to do all of it, but at least was able to spot and suggest some organizational details in the changelog that should help to not be in the way when the next sponsor comes by
I had the opportunity to do a little piloting today. Here are a few notesā¦
Uploads
- I sponsored two uploads for @ogayot today:
- khmer: Per the bug report, we have both been iterating on this package to fix Python 3.12-related tests. This upload finally passed, thanks!
- python-ulmo: bug report, MP
Workflow Notes
- Protip for sponsors: if you find yourself manually specifying
-k
, just setDEBSIGN_KEYID=<YOUR_KEYID_HERE>
in~/.devscripts
- this will pick up your key every time. - Differences in quilt configuration usually are not blockers for sponsorship (in my opinion,) unless those differences result in incompatible patches. When sponsoring khmer for @ogayot, I noticed some differences. Given some further followup, I use some sane defaults from a guide, which removes that Index header.
/etc/quilt.quiltrc
has the defaultquiltrc
, which enables the header and differences in the config. We should consider whether changing the defaults, or noting in the packaging guide, might be a good idea. Less diff lines are Usually better. - Canonical employees should note that sometimes, when using their
@canonical.com
email address, it creates a ghost Launchpad account. That karma belongs to you! Hereās an example that I discussed with @adrien today.
General Notes
- Remember, community members can patch pilot too! If youāre in ~ubuntu-dev, take a seat in the cockpit!
- Iām seeing a lot of kernel-related and security-related sponsorship queue items. For example, four of the oldest items in the queue are security updates, and many of the newer items are kernel-related patches. Like some others, I tend to not mess with anything tangential to the kernel, and I donāt have the permissions to upload to the security pocket (despite being a proud member of MOTU SWAT.) If we could get representatives from both teams to knock out these items before the holidays, Iād greatly appreciate it. Past people Iāve pinged include @xnox and @alexmurray - perhaps either of you would be able to point us in the right direction.
āExtremely Importantā Notes
- Itās python-ulmo, not python-elmo.
- Looks like the cliff turned into a valley! (Or something like that.)
- Letās keep the sponsorship queue fun, inclusive, and supportive. We Need You to hop in the cockpit today!
The sponsor queue report that the Patch Pilot team uses is the general report that excludes security and kernel uploads.
Makes sense, I didnāt notice that. Thanks.
That being said, KPI shows all items, and IMO the point still stands: red items should get appropriate attention.
Well, we can fix the KPI to track the thing weāre actually trying to drive to zero!
The other items should get attention, yes. But kernel patches in particular are not really an Ubuntu community thing.
Letās do it!
A quick point of clarification: thereās a difference, in this case, between kernel packages and kernel-adjacent packages. The former, yeah, not touching with a 10-foot pole, let Canonical Kernel take care of that. The latter gets more fuzzy, because that covers e.g. DKMS-related packages that Iād rather not touch, but donāt fall into the direct ājurisdictionā of Canonical Kernel.
Those packages will still show up, and are still on the general report, but are not something most sponsors feel comfortable touching. We should think about either asking someone from Canonical Kernel to rotate and take care of these, and/or ask skilled/willing individuals from Foundations/another team to do the same.
My shift today was affected by multiple conflicting meetings and interruptions. So I couldnāt get lots of stuff done.
- I coordinated with @tsimonq2 on IRC and was able to tackle the big
zlib
merge, at least:
Notable Achievements:
- LP: 2045000 - sponsored
- LP: 2044852 - Gave some recommendations and created a PPA to confirm the patch works
Important Context
Excited to be able to help a bit more with patch pilot now that Iām a core dev
In between meetings, I did some archaeology for the zeitgeist merge, and looked at the libgcrypt20 SRU.
Since the current queue is mostly made out of Canonical contributions, Iād like future shifts to prioritize the zeitgeist merge if possible as it is a pure community contribution.
This shift was my first patch pilot shift were I got pinged on #ubuntu-devel. It look like the patch pilot program takes off!
IRC discussions
- Intitial package review for IMSProg in Launchpad (upstream author bigmdm asked for it)
- Merge into ubuntu/devel : launchpadlib-proposed-migration : lp:~mateus-morais/ubuntu/+source/lazr.restfulclient : Git : Code : lazr.restfulclient package : Ubuntu
Uploads
- kmod - MP - reviewed, uploaded
- alex4 - LP: #2045607
- LGTM but asked for forward to Debian, then uploaded
- cracklib2 - LP: #2045290 - uploaded
- testresources - LP: #2045302 - uploaded
- u-boot-nezha - LP: #2020692 - review, offer 2 suggestions
- openjdk-21 - LP: #2036873 - do the next upload, this time for focal to use a different gcc version to fix a FTBFS there
- xserver-xorg-input-synaptics - MP - reviewed, suggested some changes
- nvme-stas LP: #2045690 / MP 456913 reviewed and sponsored
- lua-nvim LP: #2045634 reviewed and sponsored, retried build of neovim on riscv64 once lua-nvim was published
- newt LP: #2045576 / MP 456970 reviewed and sponsored
- zeitgeist MP 456270 reviewed and left a comment
Notable achievements
-
lomiri-download-manager merge: Uploaded.
-
Chromium deb version number is misleading: Uploaded to F/J/L/M.
-
oprofile FTBFS fix: Sponsored after adjusting the changelog entry and incorporating the proposed debdiff into git-ubuntu. Unfortunately the build now fails on riscv64, so I pinged Sudip about it.
-
dbus merge: Left a comment saying that I believe situation with
usr-is-merged
should be resolved first, and marked the MP as āNeeds Fixingā.
- presage merge: sponsored
- icu merge: basically did the merge again, splitting up the commits, and found issues with the previous uploads, where changes were made and not declared in d/changelog (see https://git.launchpad.net/ubuntu/+source/icu/commit/?h=import/72.1-3ubuntu2&id=9874c2f2e422a4a54dc1ff796a58cee05f0cd3d2). The merge itself carried over the ubuntu delta correctly, but I spotted something in d/rules in the debian upload and left a question (besides a bunch of comments).
- zeitgeist merge: good structured merge, easier to review than the previous ones because of the split commits. I left some comments, and requested some info. Iām not familiar with zeitgeist and desktop devel, so I was wondering if one of the patches which seem to come from the Unity era is still necessary.
These were somewhat complex reviews, so I only managed to do these 3.
- Had a long look at the lxc issue. Itās ā¦ complicated. The proposed package looks semi-reasonable and incorporates the changes requested except itās built on importing 5.0.3 into Ubuntu directly rather than applying our delta on top of the upstream Debian version (also 5.0.3). Added some comments to the ticket
- Sponsored patches for jruby (LP: #2023589)
- Reviewed picom-conf packaging (LP: #2046086); looks very good, but minor suggestion(s) to address
- Sponsored SRUs for alacarte (LP: #2037326)
-
Bug #2039873 āliblxc-dev was built with LXC_DEVEL=1 in Ubuntu 22...ā : Bugs : lxc package : Ubuntu
- waiting on reporter to fix the patch. Unsubscribed.
-
Bug #2022927 āBusybox mount fails to mount Snapsā : Bugs : busybox package : Ubuntu
- We are waiting for an upstream response here. I asked the reporter to reply to former questions which were unanswered and to update the debdiff.
-
Merge into debian/sid : ubuntu/devel : lp:~liushuyu-011/ubuntu/+source/icu : Git : Code : icu package : Ubuntu
- Provided additional feedback regarding a change that can be dropped for this merge.
I merged the icu changes in Merge into debian/sid : ubuntu/devel : lp:~liushuyu-011/ubuntu/+source/icu : Git : Code : icu package : Ubuntu
The other issues were either Incomplete or already done so I set their states accordingly, so no items remained after my shift, well two new ones appeared.