Yaru next move

Bildschirmfoto von 2019-09-02 10-25-12
Hmm, for me that popup isn’t dark anymore:
Is that supposed to be bright now?

The calender popup is bright as well now and I really think that this helps readability.

2 Likes

Adwaita has dark shell, Yaru a light one, but… :smiley:
We are evaluating which one use by default and in the future the light/dark switch is expected to have effect on Shell theme as well (not yet sure how)

1 Like

But the light one is new in Eoan? In Disco it was dark as far as I remember.

Yes it’s new in eoan
We based the shell theme again on the upstream shell and only exchanged the colours.
Upstream planned this as well for gnome 3.34 that’s were the code comes from but decided to postpone the light theme. We previously had a mixed theme as you know with popups styled like OSD, which looked great but doesn’t make much sense, and the notifications and dialogues were white. Now popups are light too because of the upstream rebase. There is not a mixed theme upstream but a full light and a full dark one.
Currently we only really fine tuned and made testing for the light variant that’s why we plan to keep it currently until a global toggle arrives and until then we need to check our fully dark theme again, currently it looks too much like milky chocolate :slight_smile:

4 Likes

What makes you think they will add a global toggle? There is no issue open (and there are many closed) for that in gnome-shell nor in gnome-control-center nor in gnome-tweaks. Plus the global toggle was deliberately removed in the past for gtk themes while the announcement suggested to add -dark theme variants (https://jeremy.bicha.net/2017/08/29/gnome-tweaks-3-25-91/). And there is a request to make dark mode dependent on… night light.

Why don’t you just add a -dark stub setting the dark variant so that we can change the shell theme from tweaks like we do with the gtk theme? Most established third party themes (adapta, materia, etc.) do that since a long time.

Besides I think it’s more important now to be able to switch to a dark shell since the new, lighter, variant won’t play quite well with yaru-dark at the app level. Imagine a white Calendar drop-down next to dark Nautilus.

1 Like

There was a lot of talk about this in gnome design calls and also some talk on guadec about this.
No idea when this is actually addressed in the code.

Use the shell in a light room, you will notice that the light shell can be much easier seen/elements can much easier differentiated.

I’m not saying I prefer a totally dark shell, just that if someone decides to go dark, by the same token he/she wants a dark shell, since every “easily differentiated elements” consideration applies to both apps and the shell.

And the stub point is that choice is a matter of just adding a five lines or so file starting with $variant=“dark”, isn’t it? This is not diverging too much from upstream (which defaults to a dark theme that, in terms of consistency, although not necessarily of usability, plays better with alternating gtk light and dark themes). So why not doing that in Ubuntu as a super simple temporary measure? That way I can go to Tweaks and set Yaru-dark for both apps and shell, as I did many times before with other themes. If they eventually add a toggle, then you can as easily revert the change by just removing the stub. Don’t you think? I get the “dark theme is not quite ready yet” point, though.

2 Likes

Hey I and everyone would love a global dark toggle!
If you have seriously an idea how this can be done propose something to the desktop team, I mean seriously :slight_smile:

Oh I thought it was understood what I was suggesting to do. Take for example Materia: https://github.com/nana-4/materia-theme/tree/master/src/gnome-shell/3.32. They have gnome-shell-dark.scss to produce gnome-shell-dark.css, they only change a couple of variables there (in the case of Yaru it would be just $variant) to produce a dark variant. Then you activate the User Shell Theme extension that is provided by Gnome out of the box (I can’t remember its exact name right now but it’s part of stock gnome-extensions) and simply pick Materia-dark for the shell theme in Tweaks. It’s exactly the same that it’s done with Yaru and Yaru-dark for apps.

Ah sorry I misunderstood you, we have a dark variant. But currently the shell theme is built with the light variant.

At the moment Ubuntu has some kind of session that loads the Ubuntu theme. Don’t ask me how this works but this won’t work with user themes I fear

Edit: here you can toggle this variable so when the scss files are loaded the value for the variant is “compiled” into the final CSS file (which is then loaded as a gresource):
https://github.com/ubuntu/yaru/blob/master/gnome-shell/src/gnome-shell.scss#L1

At the moment Ubuntu has some kind of session that loads the Ubuntu theme. Don’t ask me how this works but this won’t work with user themes I fear

See the discussion I had with Daniel van Vugt some time ago: Bug #1832137 “Can't switch between Yaru and Adwaita shell themes...” : Bugs : yaru-theme package : Ubuntu. That was about exposing a session’s default to another session with a different default (Yaru to vanilla gnome, Adwaita to ubuntu gnome). But the same logic is implied. Be careful to read it all down to the end, because there were some misunderstandings in the middle.

1 Like

TL;DR

You need to set the dark theme in /usr/share/themes/Yaru-dark/gnome-shell, maybe as a mere symlink to a new /usr/share/gnome-shell/theme/Yaru/gnome-shell-dark.css, produced exactly the same than gnome-shell.css but using $variant = "dark". This way it will be available as a shell theme in Tweaks once you enable the stock User Themes extension.

3 Likes

That’s very interesting!

2 Likes

@c-lobrano and @frederik-f I’ve created issue https://github.com/ubuntu/yaru/issues/1483 at Yaru github providing a very detailed analysis and proposal to add shell theme switching and also to allow setting Yaru shell theme in a vanilla Gnome session. As I point out at the end of the issue, I think both goals could be achieved by basic symlinking even in the git repo, without having to deal with packaging issues.

3 Likes

Mouse-over highlight of widgets in un-focused (i.e. non-current) windows seems to be missing in the new version of Yaru. I take it this is because of the wish to be closer to upstream? Any chance this could be implemented? Even better if it was in upstream - but I reported this as an issue 7 months ago :frowning:

2 Likes

That would be really great! It is a lot of work though, but it’s def. something carlo or me want to contribute to the upstream theme, thus it would then land in yaru! But not this cycle - can you link to the upstream bug?

Upstream issue for mouse-over/hover is https://gitlab.gnome.org/GNOME/gtk/issues/1606

I need to confirm, but I assume the new Yaru also suffers from the ‘No default button indicator’ issue - due to syncing with Adwaita. The upstream issue for that is https://gitlab.gnome.org/GNOME/gtk/issues/1611, and the original Yaru issue is https://github.com/ubuntu/yaru/issues/306

3 Likes

Hi,

On ubuntu 19.10 in virtualbox and yaru 19.10.1 x11 session
There is something different with the item selected on the mouse over.
The select item is not underlined. The others are underlined for exemple in the menu system

Is it a feature or is it a bug who needs to be reported?

Hi, we’ll change the hover/active colours back to gray/darker gray instead of white/orange for gtk and shell menus/popover/popups elements that are not buttons soon. It’s definitely something that should be fixed upstream but until then we’ll fix it for us

Edit: https://github.com/ubuntu/yaru/pull/1486