Patch Pilot Hand-off 24.04

Community
25

Makes sense, I didn’t notice that. Thanks.

That being said, KPI shows all items, and IMO the point still stands: red items should get appropriate attention.

1 Like
26

Well, we can fix the KPI to track the thing we’re actually trying to drive to zero!

The other items should get attention, yes. But kernel patches in particular are not really an Ubuntu community thing.

2 Likes
27

Let’s do it! :smile:

A quick point of clarification: there’s a difference, in this case, between kernel packages and kernel-adjacent packages. The former, yeah, not touching with a 10-foot pole, let Canonical Kernel take care of that. The latter gets more fuzzy, because that covers e.g. DKMS-related packages that I’d rather not touch, but don’t fall into the direct “jurisdiction” of Canonical Kernel.

Those packages will still show up, and are still on the general report, but are not something most sponsors feel comfortable touching. We should think about either asking someone from Canonical Kernel to rotate and take care of these, and/or ask skilled/willing individuals from Foundations/another team to do the same.

1 Like
28

My shift today was affected by multiple conflicting meetings and interruptions. So I couldn’t get lots of stuff done.

1 Like
29

Notable Achievements:

  • LP: 2045000 - sponsored
  • LP: 2044852 - Gave some recommendations and created a PPA to confirm the patch works

Important Context

Excited to be able to help a bit more with patch pilot now that I’m a core dev :smiley:

1 Like
30

In between meetings, I did some archaeology for the zeitgeist merge, and looked at the libgcrypt20 SRU.

Since the current queue is mostly made out of Canonical contributions, I’d like future shifts to prioritize the zeitgeist merge if possible as it is a pure community contribution.

1 Like
31

This shift was my first patch pilot shift were I got pinged on #ubuntu-devel. It look like the patch pilot program takes off!

IRC discussions

Uploads

2 Likes
32

The sponsoring report has been moved to http://sponsoring-reports.ubuntu.com/

33
  • kmod - MP - reviewed, uploaded
  • alex4 - LP: #2045607
    • LGTM but asked for forward to Debian, then uploaded
  • cracklib2 - LP: #2045290 - uploaded
  • testresources - LP: #2045302 - uploaded
  • u-boot-nezha - LP: #2020692 - review, offer 2 suggestions
  • openjdk-21 - LP: #2036873 - do the next upload, this time for focal to use a different gcc version to fix a FTBFS there
  • xserver-xorg-input-synaptics - MP - reviewed, suggested some changes
1 Like
34
1 Like
35

Raised as https://github.com/ubuntu/ubuntu-release-metrics/pull/28

2 Likes
36

Notable achievements

1 Like
37
  • presage merge: sponsored
  • icu merge: basically did the merge again, splitting up the commits, and found issues with the previous uploads, where changes were made and not declared in d/changelog (see https://git.launchpad.net/ubuntu/+source/icu/commit/?h=import/72.1-3ubuntu2&id=9874c2f2e422a4a54dc1ff796a58cee05f0cd3d2). The merge itself carried over the ubuntu delta correctly, but I spotted something in d/rules in the debian upload and left a question (besides a bunch of comments).
  • zeitgeist merge: good structured merge, easier to review than the previous ones because of the split commits. I left some comments, and requested some info. I’m not familiar with zeitgeist and desktop devel, so I was wondering if one of the patches which seem to come from the Unity era is still necessary.

These were somewhat complex reviews, so I only managed to do these 3.

1 Like
38
  • Had a long look at the lxc issue. It’s … complicated. The proposed package looks semi-reasonable and incorporates the changes requested except it’s built on importing 5.0.3 into Ubuntu directly rather than applying our delta on top of the upstream Debian version (also 5.0.3). Added some comments to the ticket
  • Sponsored patches for jruby (LP: #2023589)
  • Reviewed picom-conf packaging (LP: #2046086); looks very good, but minor suggestion(s) to address
  • Sponsored SRUs for alacarte (LP: #2037326)
1 Like
39
1 Like
40

I merged the icu changes in Merge into debian/sid : ubuntu/devel : lp:~liushuyu-011/ubuntu/+source/icu : Git : Code : icu package : Ubuntu

The other issues were either Incomplete or already done so I set their states accordingly, so no items remained after my shift, well two new ones appeared.

1 Like
41

Congratulations, we have a near-empty queue! :tada:

I’ll try to “hold down the fort” here and there over the course of the break, but there probably won’t be much to do (and I hope I’m jinxing it :slight_smile: )

image
image1908×870 59.4 KB

(Does KPI even support 0?)

2 Likes
42

Reviewed three merges done by Sudip Mukherjee.

As I lack Universe upload permissions at the moment, tsimonq2 did the actual sponsoring for all of these. I would like to thank him, vorlon, and rbasak for the additional help and guidance they provided in the process, and of course I would like to thank sudip for creating the patches. We made a great team. :slight_smile:

4 Likes
43
  • pcsx2: Uploaded pcsx2 for LP: #2048072
  • bedtools: Reviewed LP: #2048069 and proposed syncing instead. The reporter agreed and I sync’d bedtools (LP: #2048088)
  • weex: Uploaded weex to focal for LP: #1811817
2 Likes
44

Just worked on the SRU debdiffs for horst. Got them reviewed and accepted for Mantic, Lunar, and Jammy. I didn’t have time to do Focal this time around, but it’s on my radar (though if someone else wants to pick it up, that’s fine too). Bug #2045986 “[SRU] no WiFi card, ends with segfault” : Bugs : horst package : Ubuntu Thanks to @tsimonq2 for copiloting and training me during the process!

2 Likes