Firefox theming

Hello everyone,

Firefox provides some kind of adaption to the GTK3 theme.
Sadly this is sometimes limited and sometimes it takes the css part from the “wrong” place in the code.

Here are some examples:

  • Firefox can’t handle round border edges in its context-menu
    40013208-3781b944-57ad-11e8-8d26-6972376376ab
    And to cut the round corners and keep them for GTK3, we would have to make some chaos in our code, to divide the Firefox context menu from the gtk context menu.

  • Firefox provides a CSD with its latest stable release (not default but easily accessible and long awaited by many Linux users) - sadly it can’t handle the round edges of GTK3 themes here neither.
    topborderradius

  • A way of changing the theme of the whole window is als provided but in opposite to chrome or gtk3 apps Firefox also themes its headerbar with the applied theme, thus our window-decorations are laid upon their background:
    lighttheme
    40013424-c93ca132-57ad-11e8-9d9b-c12bb7f5c8fb

  • the colors of selected text are taken up from GtkTextView but from GtkView and GtkView is taken for other views as for example the nautilus main view - so we can’t have individual coloring of the text and the icon selection if we want to keep Firefox color consistent to the rest of the theme
    Peek 2018-05-15 11-44

  • the buttons in confirmation dialogues look different to ours (they actually look like gtk2?):
    image

I opened a bug about this here: https://bugzilla.mozilla.org/show_bug.cgi?id=1461621
@didrocks

@c-lobrano and @godlyranchdressing : So I would suggest to ignore firefox for the selected text and the context-menu issues at the moment and wait for a reaction/solution from Firefox :slight_smile:

5 Likes

@didrocks @jbicha

I noticed that when you install a fresh disco and start firefox in the ubuntu session OR the gnome-session, this border bleed is not visible:

image

However in communitheme or yaru development sessions it is visible. Is there anything we could do from our sides to prevent this?
Or is that a session variable thing from firefox side?

2 Likes

This is weird, I’m on an updated machine and I can’t reproduce that. However, I’m with the default (meaning, system titlebar) and not CSD. So maybe something upstream hardcoded in CSD depending on session. @oSoMoN any idea?

1 Like

This is reproducible with CSD only

1 Like

Ah yes, sorry. As @c-lobrano said, you need to un-tick this box:
image

Then the white border bleed happens with communitheme and Yaru-session but not with default ubuntu-session