- kmod - MP - reviewed, uploaded
- alex4 - LP: #2045607
- LGTM but asked for forward to Debian, then uploaded
- cracklib2 - LP: #2045290 - uploaded
- testresources - LP: #2045302 - uploaded
- u-boot-nezha - LP: #2020692 - review, offer 2 suggestions
- openjdk-21 - LP: #2036873 - do the next upload, this time for focal to use a different gcc version to fix a FTBFS there
- xserver-xorg-input-synaptics - MP - reviewed, suggested some changes
- nvme-stas LP: #2045690 / MP 456913 reviewed and sponsored
- lua-nvim LP: #2045634 reviewed and sponsored, retried build of neovim on riscv64 once lua-nvim was published
- newt LP: #2045576 / MP 456970 reviewed and sponsored
- zeitgeist MP 456270 reviewed and left a comment
Notable achievements
-
lomiri-download-manager merge: Uploaded.
-
Chromium deb version number is misleading: Uploaded to F/J/L/M.
-
oprofile FTBFS fix: Sponsored after adjusting the changelog entry and incorporating the proposed debdiff into git-ubuntu. Unfortunately the build now fails on riscv64, so I pinged Sudip about it.
-
dbus merge: Left a comment saying that I believe situation with
usr-is-merged
should be resolved first, and marked the MP as “Needs Fixing”.
- presage merge: sponsored
- icu merge: basically did the merge again, splitting up the commits, and found issues with the previous uploads, where changes were made and not declared in d/changelog (see https://git.launchpad.net/ubuntu/+source/icu/commit/?h=import/72.1-3ubuntu2&id=9874c2f2e422a4a54dc1ff796a58cee05f0cd3d2). The merge itself carried over the ubuntu delta correctly, but I spotted something in d/rules in the debian upload and left a question (besides a bunch of comments).
- zeitgeist merge: good structured merge, easier to review than the previous ones because of the split commits. I left some comments, and requested some info. I’m not familiar with zeitgeist and desktop devel, so I was wondering if one of the patches which seem to come from the Unity era is still necessary.
These were somewhat complex reviews, so I only managed to do these 3.
- Had a long look at the lxc issue. It’s … complicated. The proposed package looks semi-reasonable and incorporates the changes requested except it’s built on importing 5.0.3 into Ubuntu directly rather than applying our delta on top of the upstream Debian version (also 5.0.3). Added some comments to the ticket
- Sponsored patches for jruby (LP: #2023589)
- Reviewed picom-conf packaging (LP: #2046086); looks very good, but minor suggestion(s) to address
- Sponsored SRUs for alacarte (LP: #2037326)
-
Bug #2039873 “liblxc-dev was built with LXC_DEVEL=1 in Ubuntu 22...” : Bugs : lxc package : Ubuntu
- waiting on reporter to fix the patch. Unsubscribed.
-
Bug #2022927 “Busybox mount fails to mount Snaps” : Bugs : busybox package : Ubuntu
- We are waiting for an upstream response here. I asked the reporter to reply to former questions which were unanswered and to update the debdiff.
-
Merge into debian/sid : ubuntu/devel : lp:~liushuyu-011/ubuntu/+source/icu : Git : Code : icu package : Ubuntu
- Provided additional feedback regarding a change that can be dropped for this merge.
I merged the icu changes in Merge into debian/sid : ubuntu/devel : lp:~liushuyu-011/ubuntu/+source/icu : Git : Code : icu package : Ubuntu
The other issues were either Incomplete or already done so I set their states accordingly, so no items remained after my shift, well two new ones appeared.
Congratulations, we have a near-empty queue!
I’ll try to “hold down the fort” here and there over the course of the break, but there probably won’t be much to do (and I hope I’m jinxing it )
(Does KPI even support 0?)
Reviewed three merges done by Sudip Mukherjee.
- libtrace3. Bug #2047862 “Please merge libtrace3 3.0.22-0.1 (universe) from ...” : Bugs : libtrace3 package : Ubuntu Accepted as-is, with the recommendation that Lintian-reported problems be corrected in Debian for a future merge. Merge into debian/sid : merge-3.0.22-0.1-noble : lp:~sudipmuk/ubuntu/+source/libtrace3 : Git : Code : libtrace3 package : Ubuntu
- zeitgeist. Bug #2044300 “Please merge zeitgeist 1.0.4-5 (universe) from Deb...” : Bugs : zeitgeist package : Ubuntu Accepted with a slight tweak to the DEP3 header on /debian/patches/pre_populator.patch. Merge into debian/sid : merge-lp2044300-noble : lp:~sudipmuk/ubuntu/+source/zeitgeist : Git : Code : zeitgeist package : Ubuntu
- hosrt. Bug #2045986 “[SRU] no WiFi card, ends with segfault” : Bugs : horst package : Ubuntu Accepted as-is into Noble, SRU patches not yet handled. Comment #7 : Bug #2045986 : Bugs : horst package : Ubuntu
As I lack Universe upload permissions at the moment, tsimonq2 did the actual sponsoring for all of these. I would like to thank him, vorlon, and rbasak for the additional help and guidance they provided in the process, and of course I would like to thank sudip for creating the patches. We made a great team.
- pcsx2: Uploaded pcsx2 for LP: #2048072
- bedtools: Reviewed LP: #2048069 and proposed syncing instead. The reporter agreed and I sync’d bedtools (LP: #2048088)
- weex: Uploaded weex to focal for LP: #1811817
Just worked on the SRU debdiffs for horst. Got them reviewed and accepted for Mantic, Lunar, and Jammy. I didn’t have time to do Focal this time around, but it’s on my radar (though if someone else wants to pick it up, that’s fine too). Bug #2045986 “[SRU] no WiFi card, ends with segfault” : Bugs : horst package : Ubuntu Thanks to @tsimonq2 for copiloting and training me during the process!
- systemd-hwe (LP: #2046687): removing the ubuntu-sponsors subscription, already sponsored and SRUed
- netdata (LP: #2042644): follow-up on @bryce’s work. Small fixup, confirming the fix, updating the LP status, sponsoring the SRU into Mantic
- rsyslog (LP: #2045033): removing the ubuntu-sponsors subscription, already sponsored into Noble
- ignition-cmake (LP: #2048518), sponsored a debdiff to fix armhf autopkgtest
- cryptsetup (merge: #457969): reviewed & sponsored
- gnutls28 (merge: #458092): reviewed & sponsored with small fixup
Did a very short session - reviewed the latest patch for Bug #2045816 “project-x fails to build from source in noble” : Bugs : project-x package : Ubuntu, made a slight modification to it to make a lintian-override more specific, then uploaded it. This is my first upload as an MOTU
-
linphone (LP: #2047458): Created a ppa for the patches, tested them, then sponsored with more descriptive patch filename
-
apache2 (LP: #1947459): Verified on my end, Sergio ended up sponsoring it
- Reviewed lxc bug to update the Debian package. Tried to clarify the merge process and also did some content review.
- Reviewed backport-iwlwifi-dkms bug to fix upstream versioning change. The submitter wants to add a epoch to the version string, I am not so confident of that so did not upload the package. I believe a broader consensus is needed before performing the upload.
- Took a look at the xorg-server MP. schopin mentioned he pinged someone with xorg knowledge to review the patch but I did not find any info about this in the hand-off discourse post. Decided to not act on it since I also do not have much knowledge on xorg.
-
Reviewed MP to merge ldapscripts from Debian:
- Bug #2049311 “Please merge ldapscripts 2.0.8-2 (universe) from D...” : Bugs : ldapscripts package : Ubuntu
- My impression is that the Ubuntu delta currently in the archive is wrong, and we probably can drop it
- Replied to the MP asking for more information
-
Reviewed MP adding new patchset to xorg-server
- Merge into ubuntu/devel : tearfree : lp:~jeff250/ubuntu/+source/xorg-server : Git : Code : xorg-server package : Ubuntu
- The diff is big, I think it needs a review of somebody with some experience with the Xorg packages and QA processes. I commented on formal issues (dep-3 headers, missing bug reference, git commit history).
-
SRU double-free in Jammy iptables
- Bug #2049318 “[SRU] free(): double free detected in tcache 2” : Bugs : iptables package : Ubuntu
- Looks like a “patch on a plate” SRU case, but there are formal issues on the debdiff, I commented on those. Also: the upstream commit also a test for this issue, but that got dropped in the added d/patches patch. I asked to keep it, or to explain why we can’t.
No IRC pings to report.
I’d like to draw some attention on the xorg-server MP: the user clearly put some effort in preparing it, and it would be a pity to keep commenting on the nits (like I did) without being able to give actual feedback on the actual contents on the MP. I hope a future PP somehow familiar with xorg will be able to have a look at that diff.
- ldapscripts LP: #2049311 / MP 458569 a sync was already sponsored, so unsubscribed ubuntu-sponsors from the bug and marked the MP ‘Disapprove’
- rsyslog LP: #2045033 / MP 458725 the merge already sponsored, so set the bug status to ‘Fix Committed’ and marked the MP ‘Approve’
- cunit LP: #2049554 reviewed and sync’d
- freeradius LP: #2042824 / MR 458744 reviewed and sponsored SRU
- iptables LP: #2049318 reviewed and sponsored SRU
- There was a request on irc to help diaspora-installer migrate, it had been removed from the archive and had previous autopkgtest results, but
migration-reference/0
tests did not help. Added a hint to allow it to migrate