Patch Pilot Hand-off 25.10

  • MP: #488462 - Reviewed and sponsored
  • LP: #2109823 - Reviewed, created PPA to test builds for Questing and Plucky, and sponsored
  • LP: #2061698 - Reviewed and sponsored for noble

Review:

Sponsor:

I’m on +1 maintenance, and patch pilot. Let’s see.

As before, I’m refraining from going over sponsorships for SRU, because then I won’t be able to SRU-review those in unapproved due to conflict of interest.

Except for LP: #2115197 which I was specifically pinged about. I will block myself from doing the unapproved SRU processing portion of it then, if I sponsor this package.

  • LP: #2107773 – dovecot – Reviewed status; targetted dovecot, set openssl tasks to invalid, pushed branch with proposed changes for questing (link in bug comment 14)
  • LP: #2078947 – v4l2loopback – Reviewed status; v4l2loopback component appears finished, would appear we’re awaiting further changes on the v4l2-relayd questing branch?
  • LP: #2112632 – efibootmgr – Reviewed status; awaiting updated patch; unsubscribed sponsors
  • LP: #2112053 – pam – Reviewed merge; had some brief questions, but these were all answered very quickly and ably; sponsored for questing

https://bugs.launchpad.net/landscape-client/+bug/2087852 - needs to be checked with @juliank, as he hinted that the bug is not suitable for the general sponsorship queue.

Review:

Unsubscribed sponsors:

Sponsored:

  • LP: #2111428: sponsored for questing.
  • tcpdump merge from debian: this was merged already, marking the MP as such.
  • ubuntu-drivers-common noble PR. Left some questions in the PR. Tied to the Plucky PR. UPDATE: sponsored for plucky and noble, after getting updates to the PRs.
  • LP: #2115197: azure-proxy-agent sponsored.
  • LP: #2061698: gimp SRU: sponsored already, unsubscribing ubuntu-sponsors.
  • tomcat9 PR: marked as merged, as this was sponsored already.
  • vim merge: revewed, a couple of needs-fixing, and questions/comments about our existing delta
  • apparmor review: review requested via packages are in a ppa. I grabbed the debdiff, applied, created a branch of my own, reviewed, sponsored.
  • LP: #2115274: coreutils fix: triggered DEP8 tests for the PPA from the last comment.
  • Skipped the first couple of systemd things in the list as they were for bionic and xenial (which are EOS)
  • LP: #2087852 – landscape-client – Reviewed status; noted discrepancy in status of questing; cherry-picked fix for plucky and sponsored it into questing, left note indicating plucky and noble are probably ready for sponsorship if/when questing migrates
  • LP: #2115274 – coreutils – Reviewed status; set up PPA with all archs enabled to see if builds & tests can pass; at end of shift all but riscv64 had built successfully
  • LP: #2106757 – wsl-pro-service – Reviewed patches for plucky and noble; sponsored for plucky (with some notes about lintian errors), but not for noble as test build failed
  • landscape-client jammy MP: reviewed, requested changelog grouping. Will sponsor if the change is made during my shift. UPDATE: turns out they don’t want this to land now, but instead proceed with the formely rejected upload, which I accepted into jammy-proposed.
  • reupload ubuntu-drivers-common for LP: #2115537 which was rejected last time because of an incorrect version. I need this GH PR to land first, and then I can upload that same version to plucky-unapproved. UPDATE: sponsored anyway
  • LP: #2117127: superseeded by another merge which landed already. I closed the bug and associated PR.
  • LP: #2107340: nothing to sponsor, unsubscribed ubuntu-sponsors.
  • LP: #2119159: nothing to sponsor, unsubscribed ubuntu-sponsors.
  • LP: #2061529: nothing to sponsor, unsubscribed ubuntu-sponsors.
  • MP for libebur128: pinged author who hasn’t replied to review comment.
  • LP: #1869655: nothing to sponsor, unsubscribed ubuntu-sponsors.
  • LP: #2119014: trying to understand the situation. Looks like release upgrades from plucky could be affected, checking that.
  • LP: #2111898 – broadcom-sta – Reviewed, but left as it appears kernel need to review this SRU first
  • LP: #2114261 – broadcom-sta – Same as above
  • LP: #2110521 – sssd – Reviewed status, SRU template now looks very good, but (per last commit, #45) it appears there’s a FTBFS with the current patch
  • LP: #2117280 – octavia – Reviewed status, added note about potential improvements in test plan, sponsored for jammy
  • LP: #2116247 – firmware-sof / linux – Reviewed status, looks complete (?), unsubscribed sponsors
  • Merge – libebur128 – Reviewed status, still pending response from author, and couldn’t find any changes in Debian that would suggest the same change
  • LP: #827151 – cyrus-sasl2 – Reviewed merge proposal, left suggestions on next steps towards SRU
  • LP: #2122355 - verified update and sponsored for questing and plucky
  • LP: #2122356 - verified update and sponsored for questing, plucky, noble, and jammy
  • LP: #2091440 - reviewed and sponsored for questing, plucky, and noble
  • LP: #2108860 - reviewed and sponsored for plucky and noble
  • LP: #2115234 - reviewed and added comments for plucky

LP: #2123870: apparmor + coreutils changes (also see mailing list post):

  • LP: #2111898, LP: #2114261 – broadcom-sta – Reviewed; questing is fixed, noble SRU is await kernel review in both cases
  • LP: #2110521 – sssd – Reviewed status; targeted to questing-updates, so nothing to do until after release
  • Merge – libebur128 – No change from last time
  • LP: #827151 – cyrus-sasl2 – No change from last time
  • LP: #2116751 – openscap – Reviewed status, left some comments on odd code in the test case
  • LP: #2076101 – network-manager-openvpn – Reviewed merges, approved and sponsored for noble and jammy

Focused on clearing out older requests today, additionally did a long review for noble + jammy for LP: #2115234

The queue is not in a good shape. I removed some items that were sponsored or waited for feedback of the submitter. But I also sponsored patches that were lingering around for weeks.

I suggest the next pilot to check if there is feedback from following items and then do the sponsoring: